Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Mojolicious version? #3

Closed
eserte opened this issue Dec 10, 2019 · 1 comment
Closed

Minimum Mojolicious version? #3

eserte opened this issue Dec 10, 2019 · 1 comment

Comments

@eserte
Copy link

eserte commented Dec 10, 2019

On some of my smokers the test suite fails like this:

PERL_DL_NONLAZY=1 "/opt/perl-5.28.0/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
String found where operator expected at /home/cpansand/.cpan/build/2019121018/Mojo-File-Role-Digest-0.02-1/blib/lib/Mojo/File/Role/Digest.pm line 6, near "requires 'open'"
	(Do you need to predeclare requires?)

#   Failed test 'use Mojo::File::Role::Digest'
#   at t/00-basic.t line 35.
# syntax error at /home/cpansand/.cpan/build/2019121018/Mojo-File-Role-Digest-0.02-1/blib/lib/Mojo/File/Role/Digest.pm line 6, near "requires 'open'"
# BEGIN not safe after errors--compilation aborted at /home/cpansand/.cpan/build/2019121018/Mojo-File-Role-Digest-0.02-1/blib/lib/Mojo/File/Role/Digest.pm line 8.
# Compilation failed in require at (eval 16) line 1.
# BEGIN failed--compilation aborted at (eval 16) line 1.

#   Failed test 'Pod coverage on Mojo::File::Role::Digest'
#   at t/00-basic.t line 37.
# Mojo::File::Role::Digest: requiring 'Mojo::File::Role::Digest' failed
# Looks like you failed 2 tests of 7.
t/00-basic.t .. 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/7 subtests 
String found where operator expected at /home/cpansand/.cpan/build/2019121018/Mojo-File-Role-Digest-0.02-1/blib/lib/Mojo/File/Role/Digest.pm line 6, near "requires 'open'"
	(Do you need to predeclare requires?)
syntax error at /home/cpansand/.cpan/build/2019121018/Mojo-File-Role-Digest-0.02-1/blib/lib/Mojo/File/Role/Digest.pm line 6, near "requires 'open'"
BEGIN not safe after errors--compilation aborted at /home/cpansand/.cpan/build/2019121018/Mojo-File-Role-Digest-0.02-1/blib/lib/Mojo/File/Role/Digest.pm line 8.
Compilation failed in require at /home/cpansand/.cpan/build/2019121018/Role-Tiny-2.001004-1/blib/lib/Role/Tiny.pm line 52.

Statistical analysis suggests that this happens if Mojolicious is too old, so maybe the minimum prereq version should be adjusted:

****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name           	       Theta	      StdErr	 T-stat
[0='const']    	     -0.0000	      0.0000	  -1.14
[1='eq_8.12']  	      0.0000	      0.0000	   2.79
[2='eq_8.17']  	      0.0000	      0.0000	   0.00
[3='eq_8.23']  	      1.0000	      0.0000	9380018148277760.00
[4='eq_8.26']  	      1.0000	      0.0000	9380018148277762.00
[5='eq_8.27']  	      1.0000	      0.0000	10108205955228344.00

R^2= 1.000, N= 44, K= 6
****************************************************************
@Tekki
Copy link
Owner

Tekki commented Dec 12, 2019

Thanks for the second time. Tests pass only with Mojolicious >= 8.18,

@Tekki Tekki closed this as completed in 657ac4d Dec 12, 2019
Tekki added a commit that referenced this issue Dec 12, 2019
 - Set required Mojolicious version to 8.18
   Error reported by Slaven Rezić (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants