New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size by removing scipy #451
Comments
Pandas is only used from the test suite. Bug: #451 Change-Id: Iafd02c800e5b7772e180979d19b81a2eda0e588f
Unfortunately, numpy.interp is not equivalent to scipy.interpolate.interp1d and the latter provides more flexible usage. |
Hi @AndreaDAmico, with "inline for loop", do you mean something like:
instead of the current:
I tested this and it seems to work. In what way does it not scale properly? |
I proposed a change here: https://review.gerrithub.io/c/Telecominfraproject/oopt-gnpy/+/546806 |
Hi @ojnas, Exactly, that is the solution I was talking about. I ran some simulations changing the |
Adding gnpy (using pip install) when e.g. building an application as docker containers increases the size of the application by a few 100's of MBs, which can sometimes be a bit problematic. The main reason is the requirements, which includes some very large packages, the largest one being scipy. Searching through the code, I can only find two uses of scipy: 1) constants (which could easily be replaced by internal definitions) and 2) interp1d from scipy.interpolate (for which there is a practically equivalent function in numpy). Could removing the dependency on scipy be an option?
Another large dependency is pandas, which only seems to be used in a couple of tests.
The text was updated successfully, but these errors were encountered: