Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Metric type missing in the serialized JSON to Kafka #102

Open
ssmails opened this issue Nov 9, 2022 · 0 comments · May be fixed by #112
Open

Prometheus Metric type missing in the serialized JSON to Kafka #102

ssmails opened this issue Nov 9, 2022 · 0 comments · May be fixed by #112

Comments

@ssmails
Copy link

ssmails commented Nov 9, 2022

The prometheus metric type could be included in the searlized JSON sent to Kafka.
Having the metric type populated, would make it easier to work with the consumers of Kafka
Eg: https://docs.confluent.io/5.5.3/connect/kafka-connect-prometheus-metrics/index.html --> This assumes the metric type is included in the json added under the kafka topic.

https://github.com/Telefonica/prometheus-kafka-adapter/blob/master/serializers.go#L58

@arunsudhakar arunsudhakar linked a pull request Mar 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant