Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emojiOne support #53

Closed
Bubu opened this issue Nov 17, 2015 · 41 comments
Closed

Add emojiOne support #53

Bubu opened this issue Nov 17, 2015 · 41 comments

Comments

@Bubu
Copy link
Collaborator

Bubu commented Nov 17, 2015

Initial request was in #35.

This is important for anything < Android 4.4 as there are either no emoji or only b/w ones.

Wip here: #50
Todo:

  • Option to switch emojis
  • adjust to new emoji code
  • testing
@Ecron
Copy link

Ecron commented Nov 20, 2015

I wish I could help more actively, but I'm just a mere user with no coding knowledge.

Still I offer my help for testing purposes, at least I can do that 👍

@Ecron
Copy link

Ecron commented Dec 1, 2015

Now EmojiOnes sets the release of the 2016 Collection to December 17th (you can check their Instagram's description).

Just for everybody to know 👍

@Turakar
Copy link

Turakar commented Dec 7, 2015

+1

@emunicio
Copy link

emunicio commented Dec 7, 2015

Yes! I only have the android native emoji's (don't have the ones from google) and not only they are ugly but also some of them are missing. So it would nice fix this problem
regards

@Turakar
Copy link

Turakar commented Dec 8, 2015

The emojis from android and emojiOne are also not always equal.

@mcagl
Copy link

mcagl commented Dec 8, 2015

I'm yet on Telegram-FOSS 3.1.3 and I'm not upgrading it only because of the ugly and incomplete black android stock emojis (I cannot tell one emoji from another) (unfortunately I have android 4.1.1 and cannot easily upgrade it without buying another phone), so +1 for integrated EmojiOne in Telegram-FOSS :)

@Turakar
Copy link

Turakar commented Dec 13, 2015

For compatibilty reasons it would be good to have the same emojis as in the normal Telegram app. However I don't know the license.

@mcagl
Copy link

mcagl commented Dec 14, 2015

@Turakar Yeah, but there were months and months of discussions on that: #35
TL;DR: Those emojis are Apple's :-(

@kq01526
Copy link

kq01526 commented Dec 17, 2015

The new Emoji One 2.0 has been released today:

http://emojione.com/
https://github.com/Ranks/emojione

😉

@jomo
Copy link

jomo commented Dec 21, 2015

This is a good idea, but honestly I'd prefer if all my apps would just stick to the system emoji instead of bringing their own. (Even though I'm probably going to use EmojiOne as my system emoji anyway)

@Ecron
Copy link

Ecron commented Dec 21, 2015

@jomo It's supposed to be an option to switch off EmojiOne set and use system's.

@emunicio
Copy link

Any idea when the problem with the emojis will be fixed? I have just updated to 3.4.2 but the problem is still there: I can only see black and white ugly emojis and some of them are missing. Is this normal?

@Bubu
Copy link
Collaborator Author

Bubu commented Jan 28, 2016

No one had time to implement this yet, sorry.

@Bubu
Copy link
Collaborator Author

Bubu commented Mar 9, 2016

In the new version there will be missing emoji for everyone expect Android 6.0.1 users. (We now try to display the same emoji as the latest Telegram version, before we were still at 3.2(?) with emoji's. But Android < 6.0.1 is missing quite a few of these.)
But on the bright side it will now be easier to integrate a different emoji set. I'm quite busy right now but I'll try to look at this again when I have some time.

@Peque
Copy link

Peque commented Mar 9, 2016

@Bubu: thanks for your hard work. 😊

@Cotopaxi42
Copy link

Thanks!
Are the missing emojis new ones or old ones that we can't have anymore?

@Cotopaxi42
Copy link

Sorry for double-posting.
Issue on my Phone (Adroid 5.1.1): I can see the emojis in the "home" menu (where you see all your chats) but I can't see them in the chats themselves, they don't appear...

@NeroBurner
Copy link

Same on 4.4.4

@NeroBurner
Copy link

Emojis (android ones) are here again with 3.6.1a

@Allanitomwesh
Copy link

Hello,I have an issue with the emojis,where some are Android ones,and some are EmojiOne ones,and then there are gaps that are blank
Is there a way to use the full set of EmojiOne emojis? I don't like the Android jelly bean emojis and EmojiOne has no gaps

@Ecron
Copy link

Ecron commented Apr 1, 2016

@Allanitomwesh As far as I know, the EmojiOne set is not implemented yet in this project (www.emojione.com). How can you have issues with that iconset? Could you explain better, please?

@Allanitomwesh
Copy link

Some emojis are simply a rectangle with an X in it,when am scrolling emojis,or when someone else posts one in a chat. I'm assuming these are emojis apple have but stock android does not? (My android version is 5.0.2) I see there's a new update, maybe it fixes iit? I'll update and observe

@kq01526
Copy link

kq01526 commented Apr 5, 2016

@emunicio wrote:

not only they are ugly

It might make sense if you guys let Google know about your frustration with the Android (Noto Color Emoji) Emojis over there:

googlefonts/noto-emoji#9

😉

@Allanitomwesh
Copy link

Okay after the update still the same,also ive noticed I was simply confusing some of the emoji as EmojiOne since they look similar. There are gaps on stock android emoji (rectangles with an x)

@Bubu
Copy link
Collaborator Author

Bubu commented Apr 8, 2016

@Allanitomwesh Yes, only Android 6.0.1+ supports (almost) all of Telegram's emojis. Unfortunately there is no easy to use list to use which ones are not supported by Android 4.4/5.x. Otherwise we could filter these on older systems.
But I think I will spend time I find for working on this toward integrating the EmojiOne set.

@PanderMusubi
Copy link

@Bubu Bubu mentioned this issue Apr 29, 2016
@Allanitomwesh
Copy link

@Bubu I would like to help with any testing. I dunno how to program though.

@arielenter
Copy link

arielenter commented Sep 9, 2016

Installed version 3.10.1 from f-droit. EmojiOne haven't been implemented yet. I'll look to make a donation to the project. I hope this feature can get implemented soon :)

Thanks a lot for the great work C:

EDIT: I already donate 10 Euros :), thanks a lot for your work 👍

@Ecron
Copy link

Ecron commented Sep 24, 2016

This project seems a little in stand by, that's true.

@slp @Bubu Do you need any help here? Any update on the status of the project, maybe?

Thanks ;-)

@thermatk
Copy link
Member

thermatk commented Oct 22, 2016

Hi!
I've taken a different approach, so I generated the twemoji into the asset files with Telegram's structure. EmojiOne can't be an option until they update to include Emoji 4.0 standard: bug is here joypixels/emojione#382.
One can just replace the files in TMessagesProj/src/main/assets/emoji/
with those i have here: https://github.com/thermatk/TelegramEmojiGenerator/tree/master/workfiles/ready (don't forget to minify pngs before!). Should I send you a pull request with them @slp?
Everything to generate these pics from latest https://github.com/twitter/twemoji/releases/tag/v2.2.1 is in the folder, but it's very much a hacky workaround based on the workaround the whole emoji subsystem is in this app.

As for the option in the settings - with plain image replacements it will be pretty easy to maintain, just add the option to the settings area and replace the absolute path to assets with one including a preference. Yet putting multiple image libraries will grow the apk size a bit :) The only problem is that there are only two fonts currently ready for 4.0 - twemoji which I generated and Google Noto.
What do you think?

@thermatk
Copy link
Member

Google Noto replacements are ready as well:
https://github.com/thermatk/TgEmojiReplacer/tree/master/EMOJITOOLS/GoogleNoto/tinified

@thermatk
Copy link
Member

thermatk commented Oct 23, 2016

generated emojiOne as well, falling back to twemoji in case there is no emoji yet :)
Moved everything to a separate repo:
https://github.com/thermatk/TelegramEmojiGenerator

@Allanitomwesh
Copy link

Allanitomwesh commented Oct 27, 2016

Sweet, @Bubu @slp should totally check this out for the next F-Droid update

@slp
Copy link
Member

slp commented Nov 3, 2016

@thermatk That's cool, thanks. I've just replaced the conflicting assets with the EmojiOne+Twemoji version, and restored the original Emoji code.

@Peque
Copy link

Peque commented Nov 7, 2016

The new emoji set is beautiful and works really well. Thanks for this change! ❤️

@Bubu
Copy link
Collaborator Author

Bubu commented Nov 7, 2016

Thanks @thermatk and @slp! Closing.

@Bubu Bubu closed this as completed Nov 7, 2016
@c33s
Copy link

c33s commented Nov 7, 2016

as a user who hasn't upgraded yet i have a question:
is the new emoji set optional or am i forced to use it? really want to keep my system emojis.

@emunicio
Copy link

emunicio commented Nov 7, 2016

Big thanks for the new emoji set! Now really looks nice! :-D

@Bubu
Copy link
Collaborator Author

Bubu commented Nov 7, 2016

@c33s It is, unfortunately, not optional. I also prefer the android system emoji, but it takes much more time than we currently have for this project to develop (and more importantly maintain) the option to switch the new emojis on and off.
If someone can do that we could probably merge that, but until that happens the emojione set it is.

@thermatk
Copy link
Member

thermatk commented Nov 7, 2016

image_2016-10-23_18-07-08
@c33s If you have Xposed, you can use my module(made for PlayStore version, but I think it will work) and switch to Google Noto:
TelegramReEmoji
:)

@Allanitomwesh
Copy link

Love the new emojiset great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests