Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replies showing up as new messages #48

Open
ghost opened this issue Jun 22, 2017 · 18 comments
Open

Replies showing up as new messages #48

ghost opened this issue Jun 22, 2017 · 18 comments
Milestone

Comments

@ghost
Copy link

ghost commented Jun 22, 2017

I have telegram running on my phone and also connected to my Plasma desktop via your telepathy-morse packages.

When I reply to a message via my phone, I get a pop-up notification of that message on my desktop. Surely only genuine replies should pop-up as notifications?

@ghost
Copy link
Author

ghost commented Jun 22, 2017

telepathy-morse-br

@Kaffeine
Copy link
Member

The problem is that there is little to no workaround. Someone wants to have 'cross-device' conversation, someone like you wants to have no stupid pop-ups. There is no way to control notifications in telepathy, so I can not disable pop-up for your messages or messages that you already read on another device.

The proper solution would be to implement service-side logging in telepathy, so telepathy-morse will get the messages, but will not raise a UI for anything and everything.

The best thing I can do for now is filter out messages from yourself, if there is no active channel yet. You'll still get notifications about replies, so it would not help much.

@Kaffeine
Copy link
Member

748c790

@ghost
Copy link
Author

ghost commented Jun 22, 2017

Let me kick off a rebuild on KCI and Ill test that commit :)

@Kaffeine
Copy link
Member

Kaffeine commented Jun 22, 2017

I'm going to test the commit as soon as my TelepathyQt rebuild completed. :)

I hope it will make the client a bit less annoying.

@ghost
Copy link
Author

ghost commented Jun 22, 2017

Another little issue is history. It doesn't seem to recognise who said what :/

@Kaffeine
Copy link
Member

You are using KDE Telepathy, right? There is a number of issues in Telepathy client and I can help with KDE or Sailfish OS ones.

@ghost
Copy link
Author

ghost commented Jun 22, 2017

yes, KDE on Kubuntu 17.10

@Kaffeine
Copy link
Member

The commit seems to work as intended, so I'm going to push it soon.

@ghost
Copy link
Author

ghost commented Jun 22, 2017

ah shoot, I rebuilt using master and your fix is in wip_noNewChannelForMessageFromSelf

face palms

would you mind pushing to master?

@Kaffeine
Copy link
Member

would you mind pushing to master?

Done

@Kaffeine Kaffeine added this to the 0.2.0 milestone Jun 22, 2017
@ghost
Copy link
Author

ghost commented Jun 23, 2017

That's a lot better, thank you :)

@ghost
Copy link
Author

ghost commented Jun 23, 2017

any ETA on when 0.2.0 will be released?

@Kaffeine
Copy link
Member

@cliffordd

Another little issue is history. It doesn't seem to recognise who said what :/

I just recall what was been the problem: it is ktp-otr-proxy messing up all incoming messages. There are a number of issues and I didn't find a way to fix any of them without significant rewrite. Locally I just disabled the proxy; sadly it can only be disabled at build time by modifying CMakeLists file. If you disable it via UI, it still bypass and corrupt messages. :-(

@Kaffeine
Copy link
Member

Kaffeine commented Jun 27, 2017

@cliffordd

any ETA on when 0.2.0 will be released?

It will take me 25-45 hours to complete the release. I will spend 1-2 hours per working days and 12-16 hours per weekends, so the realistic plan is to have release in two weeks. Also, my experience says that it is better to make release at Monday. If there will be no surprises, we'll have the release by 17 [July.]

TODO:

Must-have:

Planned:

Not planned:

  • Contact search #27 (Contact search) is done (wip_contactSearch), but will not be merged until I find a capable client and test it. It seems that none of KTP or Empathy support it, so I feel free to move this to 0.3.0.

After that I'll need 2-3 hours to update README(s) and upload the release(s) as RC1.
Finally, I should write a blog post to attract more users and developers. The post can take 4-12 hours.
After that I will upload the final 0.2.0 and publish the blog post.

@Thaodan
Copy link

Thaodan commented Jul 22, 2017

Do you mean replies show up as new messages from you or the other user? Cause I go a simlar issue just with that the messages appear as the other user im chatting with.

@Kaffeine
Copy link
Member

@Thaodan , I think it is the issue with KDE Telepathy (ktp-otr-proxy corrupts message sender)
#48 (comment)

@Kaffeine
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants