LXC: Remove Device IDs #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is impossible to create LXC containers with more than one network interface, because the code of the Terraform provider includes the device id in the request to the PVE API. The API, however, does not accept such a parameter (
id).This change fixes that issue, such that containers with multiple network devices can be created.
This change removes the device ids as discussed in #98.
The question remains, why ids for devices (network, disk, etc) need to be specified by Terraform users in the first place. Since I relied on
DevicesSetToMapto parse the device configuration, this fix pursues the following approach:schema.SetDevicesSetToMap(AddIds)DevicesSetToMapWithoutId,RemoveIds)