Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters to the disk to set read/write limits #125

Merged
merged 3 commits into from
Dec 16, 2019
Merged

Add parameters to the disk to set read/write limits #125

merged 3 commits into from
Dec 16, 2019

Conversation

V-Paranoiaque
Copy link
Contributor

No description provided.

@V-Paranoiaque V-Paranoiaque mentioned this pull request Dec 8, 2019
Closed
@cospeedster
Copy link

@ggongaware

@ggongaware
Copy link
Member

Do these need to propagate through the proxmox-api-go?

@V-Paranoiaque
Copy link
Contributor Author

No need @ggongaware the parameters are added automatically by the API

@ggongaware
Copy link
Member

Do they populate as zeros '0' from the default and is that ok?

@V-Paranoiaque
Copy link
Contributor Author

V-Paranoiaque commented Dec 16, 2019 •
edited
Loading

If the parameter is omitted, the Proxmox API removes it

@ggongaware ggongaware merged commit 7adcc1b into Telmate:master Dec 16, 2019
@V-Paranoiaque V-Paranoiaque deleted the feature/mbps branch December 16, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@V-Paranoiaque @cospeedster @ggongaware