Add option to not start vm on create #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggongaware can i plz have some help with the tests on this? i can do the build fine, and manual run works, but not good enough with go to get the tests passing. |
ggongaware
reviewed
Nov 12, 2021
ggongaware
reviewed
Nov 12, 2021
This was referenced Nov 16, 2021
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #435
default is still to power on when vm is created so no backwards breaking change. users should see no difference with new option.
if set to false the vm will not be powered on after it is created. followed naming on
onbootand updated docs with new option.maintainer can edit if needed for new name or docs explanation. if tests are needed i might need help, couldnt figure out how to write them, i am new to go