-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(pxe): Add Network PXE boot option, doc, and examples #492
Conversation
@mleone87 - thank you for your help with merging the upstream options in to Telemate/proxmox-api-go which I submitted. Hoping that you can help move this through, tag, and release (presumably v2.9.5) this enhancement. Much appreciated! My apologies about the go.mod and go.sum conflicts - I'm not sure what I'm supposed to do with those to prevent the conflicts. I bumped the
Then did |
Ok - corrected the conflicts ... I failed to re-sync my Fork prior to generating the go.mod and go.sum changes. I thought I was working off of the freshest set of changes. |
@mleone87 - I might have fixed the test failures. I am not able to replicate running the tests in my environment, so I'm not certain on that. |
great work! |
@mleone87 - what is the process to have the 2.9.5 release provider made available in the Terraform registry ? Is there something else I need to do to make that happen ? Or am I just being too impatient waiting for it to be pushed up ? Thank you for your help in ushering this through and being patient with me. |
Nothing, the release process already creates the assets and terraform already pulls them |
This is problematic for setting up a VM from PXE:
We shouldn't need to have network boot as the first option. Having boot to disk, then PXE, makes sense when you need to do an initial install of a VM through PXE, but want boot directly from disk afterwards. |
@jValdron - a commit has already been made to adjust the validation to check that "network" exists "somewhere" in the boot order, but is no longer required as the first option. In our use cases, Network is always first, and out infrastructure automation always controls what the Node or Machine should boot to on next boot. This allows the automation to boot systems, and take back control for things like BIOS updates, Firmware updates, decommissioning, recommissioning, audit compliance checks, maintenance break/fix reasons, etc. |
Adds support to the Terraform Provider Proxmox capabilities for PXE booted VMs. Addresses the following reported issues:
The following changes have been made:
proxmox-api-go
PXE feature added at commit20220113001728-0c6f43a60b62
pxe = true
in Terraform resource definition, which is exclussive of Clone and ISO modesboot
options to ensure a Network boot order is set firstvm_qemu.md
go.mod
andgo.sum
appropriatelypxe_example.tf
sampleIf this PR is accepted, I would ask that a new Release (presumably v2.9.5) be cut, so the requires statements will pull in the right version with the PXE support.