Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boot order option documentation, disallow deprecated syntax #668

Merged
merged 6 commits into from Feb 2, 2023

Conversation

tnyeanderson
Copy link
Contributor

@tnyeanderson tnyeanderson commented Jan 23, 2023

The syntax described in the documentation does not work (it has been deprecated). This fixes the regex check on the value so it will fail if the correct syntax isn't used, and updates the documentation to accurately reflect upstream.

The long version: using acdn-style boot order has been deprecated, and now you must use e.g. legacy=acdn or order=device1;device2

EDIT: legacy= doesn't work either, the whole thing needs deprecated. See my comment below.

@tnyeanderson
Copy link
Contributor Author

tnyeanderson commented Jan 23, 2023

Nevermind, just tested with the legacy=cdn label and that doesn't work either. I think this is because it states in the documentation that only devices listed in order= will be marked as bootable. And if you look at the boot order in the GUI using legacy= the disk (scsi0) will not be checked.

Point of this is to support PXE-based installations. The answer is to use the equivalent order=ide2;scsi0;net0 value, which does work, but isn't necessarily as flexible (you have to specify exact device names instead of "any disk, then any cd, then any network").

Since this basically completely breaks the legacy, deprecated notation, it probably shouldn't be supported in this provider either :)

@tnyeanderson tnyeanderson changed the title Fix pxe boot order Fix boot order option documentation, disallow deprecated syntax Jan 23, 2023
@mleone87 mleone87 merged commit 5d8bebc into Telmate:master Feb 2, 2023
@tnyeanderson tnyeanderson deleted the fix-pxe-boot-order branch February 2, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants