Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change backup disk option to boolean #669

Merged
merged 2 commits into from Feb 2, 2023

Conversation

tnyeanderson
Copy link
Contributor

In the upstream docs the backup option is a boolean.

See reasoning in Telmate/proxmox-api-go#231 for why the default value is true. That PR and this one should finally allow backups to be disabled.

Fixes: #429

@tnyeanderson
Copy link
Contributor Author

tnyeanderson commented Jan 24, 2023

Looks like the container side is already correct.

By default additional mount points besides the Root Disk mount point are not included in backups. For volume mount points you can set the Backup option to include the mount point in the backup. Device and bind mounts are never backed up as their content is managed outside the Proxmox VE storage library.

This has been tested with the PR from proxmox-api-go and should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to disable disk backup
2 participants