Add new vm_state attribute to manage running/stopped VMs #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in two cases: - when some VMs should be stopped (for security reasons or maintenance): this is now possible from Terraform - when a VM has been stopped manually in Proxmox: Terraform will now start the VM when applying the configuration This deprecates the "oncreate" attribute following the guidelines from https://developer.hashicorp.com/terraform/plugin/sdkv2/best-practices/deprecations#renaming-an-optional-attribute
|
nice one, thanks |
|
hello @jonglezb please notice that setting the vm_state as "stopped" when the vm is running will stop the vm as intended. |
|
Strange, it should work, I did test this feature before submitting (this is my main use-case). Can you give more information about how you run this? Any debug log? |
|
that's easy to spot, maybe your are not using agent=1 parameter? The actual code order in update function checks for the ip before starting the vm and goes on for 20min at least. then it arrives to the code that powers on the vm I'll make a fix later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in two cases:
when some VMs should be stopped (for security reasons or maintenance): this is now possible from Terraform
when a VM has been stopped manually in Proxmox: Terraform will now start the VM when applying the configuration
This deprecates the "oncreate" attribute following the guidelines from https://developer.hashicorp.com/terraform/plugin/sdkv2/best-practices/deprecations#renaming-an-optional-attribute