Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smbios support for Qemu guest VM #736

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

lsjostro
Copy link
Contributor

@lsjostro lsjostro commented Apr 3, 2023

This implements smbios block to be able to set smbios parameters. i.e Can be used to override NoCloud database source in cloud-init.

@glitchcrab
Copy link
Contributor

Thanks for doing this - I was planning on adding support for it myself.

@mleone87 mleone87 merged commit 5ecdd4d into Telmate:master Apr 11, 2023
1 check passed
@mleone87
Copy link
Collaborator

mleone87 commented Apr 18, 2023

@lsjostro code as it is force the removal of the uuid parameter at every terraform plan, did you encounter this?

Terraform will perform the following actions:

  # proxmox_vm_qemu.test[0] will be updated in-place
  ~ resource "proxmox_vm_qemu" "test" {
        id                        = "node/qemu/100"
        name                      = "node"
        # (42 unchanged attributes hidden)

      - smbios {
          - uuid = "acfbdeb3-ad6b-4ef8-ae60-f85c6f74b9b2" -> null
        }

        # (2 unchanged blocks hidden)
    }

context; a simple tf plan with no smsbios parameters at all, I get what proxmox creates automatically

@lsjostro
Copy link
Contributor Author

lsjostro commented Apr 18, 2023

Yes, saw it the other day as well. If one don't fiddle with smbios it should leave it alone. Maybe it should be set to nil in the go API lib.. or unset somehow? As now the Smbios1 struct field is a string and a string that is not set will be empty string ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants