Feat: Gracefully shutdown VM on deletion. #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows things like DHCP reservations to be cleaned up.
spettinichi
pushed a commit
to spettinichi/terraform-provider-proxmox
that referenced
this pull request
Jan 26, 2024
* Gracefully shutdown VM on deletion. This allows things like DHCP reservations to be cleaned up. * Attempt graceful shutdown only if guest agent is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters
resourceVmQemuDeleteto attempt a graceful VM shutdown prior deletion (as opposed to the current method which performs a hard stop). With the current behavior, DHCP reservations are left hanging until a timeout (which can take quite some time), leading to potentially lots of unavailable IP addresses.