Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to PyScss v1.3.5 causes icons to use wrong 'content' #19

Closed
hurgleburgler opened this issue Jun 9, 2016 · 1 comment
Closed

Upgrading to PyScss v1.3.5 causes icons to use wrong 'content' #19

hurgleburgler opened this issue Jun 9, 2016 · 1 comment
Labels
question

Comments

@hurgleburgler
Copy link

Using this webfont with the latest PyScss v1.3.5 (released today), causes breakage. Honestly not sure if the breakage is on the side of PyScss or this package, any direction would be greatly appreciated.

Before the upgrade: https://i.imgur.com/0D0x5Bs.png
After the upgrade: https://i.imgur.com/ZDvWlai.png
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Jun 10, 2016
@openstack-gerrit
Updated openstack/openstack
e2c003f 
Project: openstack/requirements  2b2c9882bbd104b229f6ee01ed205dde4059df7a

Skip latest verison of PyScss until bug resolved

Latest version of PyScss breaks MDI Web Font.

Templarian/MaterialDesign-Webfont#19

Change-Id: Ie71608dca7008f62b3e50ba55bb2c06153ba439e
openstack-gerrit pushed a commit to openstack/requirements that referenced this issue Jun 10, 2016
@hurgleburgler
Skip latest verison of PyScss until bug resolved
caf1ec4 
Latest version of PyScss breaks MDI Web Font.

Templarian/MaterialDesign-Webfont#19

Change-Id: Ie71608dca7008f62b3e50ba55bb2c06153ba439e
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Jun 10, 2016
@openstack-gerrit
Updated openstack/openstack
36d63e1 
Project: openstack/requirements  2b2c9882bbd104b229f6ee01ed205dde4059df7a

Skip latest verison of PyScss until bug resolved

Latest version of PyScss breaks MDI Web Font.

Templarian/MaterialDesign-Webfont#19

Change-Id: Ie71608dca7008f62b3e50ba55bb2c06153ba439e
@Templarian
Copy link
Owner

Can you retest this @hurgleburgler? The latest v1.7.12 contained a lot of changes, one of them may have fixed this.

openstack-gerrit pushed a commit to openstack/horizon that referenced this issue Mar 25, 2020
@e0ne @amotoki
Fix Horizon to work with the latest pyScss
ddc52a7 
pyScss v1.3.5 implements 'function-exists' function now. It breaks
MaterialDesign-Webfont [1] which is provided by xstatic-mdi package.

This patch re-implements FontAwesome-based styles for Material theme to
not use MaterialDesign-Webfont classes.

Another advantage of this improvement is we can use the latest pyScss
(once it'll be released) and update xstatic-mdi too.

[1] Templarian/MaterialDesign-Webfont#19

Closes-Bug: #1771559
Depends-On: https://review.opendev.org/714450
Change-Id: Ia9e1e807591d4428f585177f521d4cb9d463b917
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Mar 25, 2020
@e0ne @openstack-gerrit
Update git submodules
fb3ab99 
* Update horizon from branch 'master'
  - Fix Horizon to work with the latest pyScss
    
    pyScss v1.3.5 implements 'function-exists' function now. It breaks
    MaterialDesign-Webfont [1] which is provided by xstatic-mdi package.
    
    This patch re-implements FontAwesome-based styles for Material theme to
    not use MaterialDesign-Webfont classes.
    
    Another advantage of this improvement is we can use the latest pyScss
    (once it'll be released) and update xstatic-mdi too.
    
    [1] Templarian/MaterialDesign-Webfont#19
    
    Closes-Bug: #1771559
    Depends-On: https://review.opendev.org/714450
    Change-Id: Ia9e1e807591d4428f585177f521d4cb9d463b917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Templarian @hurgleburgler