Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Nested Menu as Promise #52

Merged
merged 3 commits into from
Apr 19, 2016
Merged

Conversation

josetaira
Copy link
Collaborator

This commit allows you to pass a promise as your Nested Menu.

@Templarian Templarian merged commit b65698f into Templarian:master Apr 19, 2016
@Templarian
Copy link
Owner

Now I didn't actually have time yet to read your commit, just merging and am review it as I test it out. 😄 (my other open source project is taking all my time, but I don't want to ignore this, just cutting corners).

@josetaira
Copy link
Collaborator Author

@Templarian no worries. I tried to make as small a change as possible but still implementing the required features. Shouldn't be too difficult to test it out.

Have you considered adding other people with write access to this repo to help you out?

@Templarian
Copy link
Owner

Templarian commented Apr 19, 2016

@josetaira Good idea! You're a contributor now (probably should have done this sooner, but these github emails get buried by all the activity of my main project). Open an issue when you think it's ready for a version bump and I'll increment and release. We just need to make sure we don't break the current user's stuff and that the docs are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants