Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal logical type schema json representation is inconsistent with Java impl #22

Open
Ten0 opened this issue Jul 6, 2024 · 0 comments · May be fixed by #23
Open

Decimal logical type schema json representation is inconsistent with Java impl #22

Ten0 opened this issue Jul 6, 2024 · 0 comments · May be fixed by #23

Comments

@Ten0
Copy link
Owner

Ten0 commented Jul 6, 2024

I initially wrote it correctly because that's how I understood it following the spec and was what felt like it had the most sense, but then when my interop tests with apache-avro were failing I assumed I got it wrong and spent 2 hours doing this refactor:
8f73223 (#9)

Turns out, of course it was the rust apache-avro crate that was wrong, and I should have kept the previous implementation 😑:
https://issues.apache.org/jira/browse/AVRO-3925

=> We should revert this. (logical type attributes should be flattened with the original type and name)
Unfortunately this probably means that we should also revert the schema representation update because that means that the original one was more appropriate (notably with regards to name resolution) if indeed we don't need to support the current representation, but that's a breaking change so it will require a new major version. ☹️

@Ten0 Ten0 changed the title Decimal logical type schema serialization is incorrect Decimal logical type schema json representation is incorrect Jul 6, 2024
@Ten0 Ten0 changed the title Decimal logical type schema json representation is incorrect Decimal logical type schema json representation is inconsistent with Java impl Jul 6, 2024
@Ten0 Ten0 linked a pull request Jul 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant