Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to get the answer in Spanish #2

Closed
rdeago opened this issue Oct 6, 2022 · 1 comment
Closed

Add a method to get the answer in Spanish #2

rdeago opened this issue Oct 6, 2022 · 1 comment
Labels
closed-as:wontfix [issue] is valid, but will not be acted upon (see comments). easy [issue] is easy to grasp, a good pick for new collaborators. enhancement [issue/PR] requests / implements new or improved functionality.

Comments

@rdeago
Copy link
Member

rdeago commented Oct 6, 2022

Reference version

1.0.1-preview

Background and motivation

We all know how important the Answer is.

As a matter of fact, the team here has already gone to great lengths to provide every user with the Answer: we can get it in binary form simply by calling Aaa.GetTheAnswer(), or even as Italian text with Aaa.GetTheAnswerInItalian().

What's missing IMHO is a method to retrieve this essential piece of information in Spanish. Spanish has a lot more speakers than Italian, so a GetTheAnswerInSpanish method would allow applications to support a much greater number of users.

Proposed enhancement

Add to the Aaa class a method (probably called GetTheAnswerInSpanish) that returns the Answer in Spanish.

Implementation proposals

The implementation could be similar to GetTheAnswerInItalian. Namely:

  • use a constant for the actual value returned;
  • return a string on older frameworks and a ReadOnlySpan<char> on frameworks with span support.

Usage examples

Given this code:

Console.WriteLine(Aaa.GetTheAnswerInSpanish());

the console output should be:

Cuarenta y dos

Risks

I don't see any risks potentially arising from this improvement, as existing code would not be modified and the new methods, if correctly implemented, shouldn't present any particular security risk.

Additional information

I have nothing else to say, but hey, this form won't test itself, right?

@rdeago rdeago added enhancement [issue/PR] requests / implements new or improved functionality. easy [issue] is easy to grasp, a good pick for new collaborators. area:aaalib labels Oct 6, 2022
@rdeago rdeago added this to the 1.1.0 milestone Oct 9, 2022
@rdeago rdeago modified the milestones: 1.1.0, 2.0 Nov 9, 2022
@rdeago rdeago added the closed-as:wontfix [issue] is valid, but will not be acted upon (see comments). label Nov 11, 2022
@rdeago rdeago removed this from the 2.0 milestone Nov 11, 2022
@rdeago
Copy link
Member Author

rdeago commented Nov 11, 2022

Closing this as the entire Aaa class is going away as per #17

@rdeago rdeago closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-as:wontfix [issue] is valid, but will not be acted upon (see comments). easy [issue] is easy to grasp, a good pick for new collaborators. enhancement [issue/PR] requests / implements new or improved functionality.
Projects
None yet
Development

No branches or pull requests

2 participants