Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 catch information of Error-Prone #780

Merged
merged 6 commits into from
Mar 2, 2023
Merged

🎨 catch information of Error-Prone #780

merged 6 commits into from
Mar 2, 2023

Conversation

didebughu
Copy link
Collaborator

No description provided.

@cyw3 cyw3 self-requested a review February 24, 2023 02:06
@cyw3 cyw3 linked an issue Feb 24, 2023 that may be closed by this pull request
Copy link
Collaborator

@cyw3 cyw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
注意补充对应的使用文档。

@didebughu
Copy link
Collaborator Author

补充Error-Prone使用文档

> Error Prone是google开源的Java编译时检测工具,将常见的Java错误捕获为编译时错误,增强对java代码的类型分析,从而让开发人员及时发现问题

## TCA使用指引
由于Error Prone同为编译时检测工具,已添加规则至JavaWarning工具以增强类型检测。建议采用客户端本地分析模式以满足编译条件,参考[编译配置](../../../guide/分析方案/代码检查编译配置.md),Error Prone客户端配置和编译命令可参考文档下文。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要详细写下:

  • TCA集成方式。第一句有点表意不清,javawarning是什么?error prone跟javawarning的关系是?为什么这样集成?等问题需要解释下。
  • 配置步骤尽可能详细些,比如
      1. 在规则包中增加 JavaWarning 中对应 errorp prone的规则(如何在javawarning中区分出error prone规则?);
      1. TCA Client采用何种方式调用?需要怎么进行编译上的配置(可以跳转到下面)
      1. 启动分析,TCA Web页面上查看问题。

> Error Prone是google开源的Java编译时检测工具,将常见的Java错误捕获为编译时错误,增强对java代码的类型分析,从而让开发人员及时发现问题

## TCA使用指引
由于Error Prone同为编译时检测工具,已添加规则至JavaWarning工具以增强类型检测。建议采用客户端本地分析模式以满足编译条件,参考[编译配置](../../../guide/分析方案/代码检查编译配置.md),Error Prone客户端配置和编译命令可参考文档下文。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

跟上面的一样。

Copy link
Collaborator

@cyw3 cyw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyw3 cyw3 merged commit e072003 into Tencent:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

集成Error Prone代码扫描工具
2 participants