[Bugfix] Fix uncorrect index file #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerqi UT is needed for the bug fix |
done |
jerqi
added a commit
that referenced
this pull request
Mar 8, 2022
### What changes were proposed in this pull request? Modify the method that calculate the offset in the index file. ### Why are the changes needed? If we don't have this patch, we run 10TB tpcds, query24a will fail. <img width="361" alt="企业微信截图_6dc451cf-dbf4-4257-b680-e79346cd582d" src="https://user-images.githubusercontent.com/8159038/157178756-d8a39b3f-0ea6-4864-ac68-ee382a88bb0f.png"> When we write many data to dataOutputStream, dataOutputStream.size() won't increase again. dataOutputStream.size() will always be Integer.MAX_VALUE. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add new uts. Co-authored-by: roryqi <roryqi@tencent.com>
jerqi
added a commit
to jerqi/Firestorm
that referenced
this pull request
Mar 8, 2022
### What changes were proposed in this pull request? Modify the method that calculate the offset in the index file. ### Why are the changes needed? If we don't have this patch, we run 10TB tpcds, query24a will fail. <img width="361" alt="企业微信截图_6dc451cf-dbf4-4257-b680-e79346cd582d" src="https://user-images.githubusercontent.com/8159038/157178756-d8a39b3f-0ea6-4864-ac68-ee382a88bb0f.png"> When we write many data to dataOutputStream, dataOutputStream.size() won't increase again. dataOutputStream.size() will always be Integer.MAX_VALUE. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add new uts. Co-authored-by: roryqi <roryqi@tencent.com>
jerqi
added a commit
that referenced
this pull request
Mar 8, 2022
backport 0.3.0 ### What changes were proposed in this pull request? Modify the method that calculate the offset in the index file. ### Why are the changes needed? If we don't have this patch, we run 10TB tpcds, query24a will fail. <img width="361" alt="企业微信截图_6dc451cf-dbf4-4257-b680-e79346cd582d" src="https://user-images.githubusercontent.com/8159038/157178756-d8a39b3f-0ea6-4864-ac68-ee382a88bb0f.png"> When we write many data to dataOutputStream, dataOutputStream.size() won't increase again. dataOutputStream.size() will always be Integer.MAX_VALUE. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add new uts. Co-authored-by: roryqi <roryqi@tencent.com>
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modify the method that calculate the offset in the index file.
Why are the changes needed?
If we don't have this patch, we run 10TB tpcds, query24a will fail.
When we write many data to dataOutputStream, dataOutputStream.size() won't increase again. dataOutputStream.size() will
always be Integer.MAX_VALUE.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add new uts.