Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): websocket url add hash and close with code and reason #1447

Merged
merged 5 commits into from Jan 17, 2022
Merged

feat(ios): websocket url add hash and close with code and reason #1447

merged 5 commits into from Jan 17, 2022

Conversation

Nolantang
Copy link
Contributor

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

ozonelmy
ozonelmy approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@ozonelmy ozonelmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozonelmy ozonelmy merged commit 9160897 into Tencent:master Jan 17, 2022
ozonelmy pushed a commit that referenced this pull request Jan 17, 2022
@Nolantang @shenchaoran @ozonelmy
feat(ios): websocket url add hash and close with code and reason (#1447)
0aea441 
* feat(ios): websocket close with code and reason

* feat(hippy-vue-demo): add remote bundle entry

* feat(vue-demo): add TestModule.remoteDebug API

* feat(ios): websocket url add hash

* feat(ios): TestModule add remoteDebug

Co-authored-by: chestershen <chestershen@tencent.com>
zoomchan-cxj pushed a commit that referenced this pull request Feb 9, 2022
@Nolantang @shenchaoran @zoomchan-cxj
feat(ios): websocket url add hash and close with code and reason (#1447)
3365605 
* feat(ios): websocket close with code and reason

* feat(hippy-vue-demo): add remote bundle entry

* feat(vue-demo): add TestModule.remoteDebug API

* feat(ios): websocket url add hash

* feat(ios): TestModule add remoteDebug

Co-authored-by: chestershen <chestershen@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozonelmy ozonelmy ozonelmy approved these changes

@churchill-zhang churchill-zhang Awaiting requested review from churchill-zhang

@ilikethese ilikethese Awaiting requested review from ilikethese

@siguangli siguangli Awaiting requested review from siguangli

@zoomchan-cxj zoomchan-cxj Awaiting requested review from zoomchan-cxj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nolantang @ozonelmy @shenchaoran