Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): podspec lint error & enable Module import #2935

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Feb 15, 2023

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@github-actions github-actions bot added build: xcode size: s Denotes a PR that changes 10-99 lines labels Feb 15, 2023
@hippy-service
Copy link

hippy-service bot commented Feb 15, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@ozonelmy ozonelmy self-requested a review February 15, 2023 09:57
1. fix CLANG_CXX setting may be conflict with other pods
2. podspec now support local development use
module import is not currently supported
@github-actions github-actions bot added framework: ios size: m Denotes a PR that changes 100-499 lines and removed size: s Denotes a PR that changes 10-99 lines labels Feb 15, 2023
@wwwcg wwwcg changed the title fix(ios): podspec lint error and config conflicts fix(ios): podspec lint error & enable Module import Feb 15, 2023
Copy link
Contributor

@ozonelmy ozonelmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hippy-service
Copy link

hippy-service bot commented Feb 18, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@ozonelmy ozonelmy added the action(squash-merge) Squash and merge action label Feb 18, 2023
@hippy-actions hippy-actions bot enabled auto-merge (squash) February 18, 2023 06:58
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Feb 18, 2023
@hippy-actions hippy-actions bot merged commit 540beeb into Tencent:master Feb 18, 2023
zoomchan-cxj pushed a commit that referenced this pull request Feb 20, 2023
* fix(ios): podspec lint error and config conflicts

1. fix CLANG_CXX setting may be conflict with other pods
2. podspec now support local development use
module import is not currently supported

* feat(ios): enable clang module import
zoomchan-cxj pushed a commit that referenced this pull request Mar 21, 2023
* fix(ios): podspec lint error and config conflicts

1. fix CLANG_CXX setting may be conflict with other pods
2. podspec now support local development use
module import is not currently supported

* feat(ios): enable clang module import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build: xcode framework: ios size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants