Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cleanLog in tswconfig.js to hide default logs #449

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

Zack921
Copy link
Collaborator

@Zack921 Zack921 commented Jun 1, 2021

Checklist:

@Zack921 Zack921 requested a review from mapleeit June 1, 2021 11:13
@Zack921
Copy link
Collaborator Author

Zack921 commented Jun 1, 2021

@mapleeit
相关issue: #413
当前效果
image

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #449 (8e4d573) into master (0d64d8a) will decrease coverage by 0.83%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   89.16%   88.33%   -0.84%     
==========================================
  Files          20       20              
  Lines         646      660      +14     
  Branches      102      108       +6     
==========================================
+ Hits          576      583       +7     
- Misses         69       76       +7     
  Partials        1        1              
Impacted Files Coverage Δ
lib/core/runtime/capture/index.ts 77.37% <0.00%> (-2.94%) ⬇️
lib/core/logger/index.ts 81.88% <71.42%> (-0.62%) ⬇️
lib/core/runtime/dns.hack.ts 86.27% <100.00%> (ø)
lib/index.ts 84.37% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d64d8a...8e4d573. Read the comment docs.

Copy link
Collaborator

@mapleeit mapleeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to change the behavior of logger inside. Use a flag outside is a little tricky and redundant.

implement cleanLog in logger inside
@Zack921 Zack921 merged commit 037b090 into Tencent:master Jun 2, 2021
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants