Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8: Add issue templates #14

Merged
merged 1 commit into from Sep 18, 2019
Merged

Issue 8: Add issue templates #14

merged 1 commit into from Sep 18, 2019

Conversation

tisonkun
Copy link
Contributor

Visual results with this patch

issue-template-0

issue-template-1

issue-template-2

issue-template-3

You can also try it out by creating issues in https://github.com/TisonKun/TubeMQ (issues -> New Issue)

close Tencent#8

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

@gosonzhang @yiheng @guangxuCheng Could you take a look?

@guangxuCheng
Copy link
Collaborator

lgtm

@tisonkun
Copy link
Contributor Author

Thanks for your review @guangxuCheng! I don't have write access to the repo so it would be helpful if you help to merge it.

Besides, I am not sure whether the format "Issue 8: ..." is ok. But before a standard output from #15 all readable format should be valid.

@yiheng
Copy link
Contributor

yiheng commented Sep 18, 2019

This looks great. Only one concern, have we decided to use github issues to manage our tickets?

@tisonkun
Copy link
Contributor Author

@yiheng At least RocketMQ adopts GitHub issue as issue tracker so I think it wouldn't be a blocker that we use GitHub issue as issue tracker.

I agree that it is an open issue which issue tracker we finally adopt. But it wouldn't block this pull request that we make current state a bit better.

@yiheng yiheng merged commit 3560aca into Tencent:master Sep 18, 2019
@tisonkun tisonkun deleted the issue-8 branch September 27, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants