Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue #107 and issue #106 #108

Merged
merged 2 commits into from Jul 30, 2019
Merged

fix: issue #107 and issue #106 #108

merged 2 commits into from Jul 30, 2019

Conversation

vabaly
Copy link
Contributor

@vabaly vabaly commented Jul 29, 2019

@tencent-adm
Copy link

tencent-adm commented Jul 29, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jul 29, 2019 •
edited

Codecov Report

Merging #108 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   93.44%   93.46%   +0.02%     
==========================================
  Files          11       11              
  Lines         305      306       +1     
  Branches       38       38              
==========================================
+ Hits          285      286       +1     
  Misses         20       20
Impacted Files Coverage Δ
lib/core/index.js 76% <100%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d8c39...562fee5. Read the comment docs.

cpselvis
cpselvis approved these changes Jul 30, 2019
View reviewed changes
Copy link
Collaborator

@cpselvis cpselvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@cpselvis cpselvis merged commit a28d386 into Tencent:master Jul 30, 2019
@fXy-during fXy-during mentioned this pull request Nov 4, 2019
Closed
@xkelvinx666 xkelvinx666 mentioned this pull request Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpselvis cpselvis cpselvis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vabaly @tencent-adm @codecov-io @cpselvis