Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Move more common methods to base of AttributeConfig<T> #43

Merged
merged 1 commit into from Jan 20, 2022

Conversation

xndcn
Copy link
Contributor

@xndcn xndcn commented Jan 19, 2022

  1. Move more common methods to base of AttributeConfig, decrease source lines from ~750 to ~500
  2. Move partial specialization functions into Attributes.cpp, so when it is modified, there is no need to re-compile whole sources which include Attributes.h

@xndcn xndcn changed the title [refractor] Move more common methods to base of AttributeConfig<T> [refactor] Move more common methods to base of AttributeConfig<T> Jan 19, 2022
@domchen domchen merged commit 1f7189d into Tencent:main Jan 20, 2022
@domchen
Copy link
Collaborator

domchen commented Jan 22, 2022

@xndcn Declaring specializations in a CPP file causes the PAG decoding to fail on Android. I will revert this pr.
The standard strongly encourages us not to do this, discussed in: https://stackoverflow.com/questions/30530364/explicit-specialization-of-member-function-template-in-source-file Besides, the Attributes.h file have never changed during the last five years.

@xndcn
Copy link
Contributor Author

xndcn commented Jan 24, 2022

@domchen Sorry about it 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants