Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add interp layer supporting nearest and bilinear #155

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

lzx1413
Copy link
Contributor

@lzx1413 lzx1413 commented Oct 8, 2017

No description provided.

@lzx1413 lzx1413 changed the title add interp layer support nearest and bilinear add interp layer supporting nearest and bilinear Oct 8, 2017
@nihui
Copy link
Member

nihui commented Oct 9, 2017

assigning raw data pointer directly is wrong, usually leads to memory leaks and double free error
check size equality before creating top_blob
and use top_blob = bottom_blob for the same size

       if(oh == h && ow == w) {
           top_blob.data = bottom_blob.data;
           return 0;
       }

please follow the coding style of the existing layer implementation, such as no space idents within namespace scope.

@lzx1413
Copy link
Contributor Author

lzx1413 commented Oct 9, 2017

Ok I'll fix it soon

@lzx1413
Copy link
Contributor Author

lzx1413 commented Oct 9, 2017

should I move the neon part code into arm folder?

@lzx1413 lzx1413 force-pushed the upstream branch 2 times, most recently from 46a5e33 to 0d5366d Compare October 9, 2017 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants