Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeformableConv2D #4070

Merged
merged 16 commits into from Jul 28, 2022
Merged

Add DeformableConv2D #4070

merged 16 commits into from Jul 28, 2022

Conversation

miemie2013
Copy link
Contributor

Add DeformableConv2D

@tencent-adm
Copy link

tencent-adm commented Jul 22, 2022

CLA assistant check
All committers have signed the CLA.

Add DeformableConv2D
Add DeformableConv2D
Add DeformableConv2D
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #4070 (c405dfd) into master (4f414c1) will decrease coverage by 0.21%.
The diff coverage is 97.60%.

@@            Coverage Diff             @@
##           master    #4070      +/-   ##
==========================================
- Coverage   94.41%   94.20%   -0.22%     
==========================================
  Files         745      744       -1     
  Lines      178496   178509      +13     
==========================================
- Hits       168533   168162     -371     
- Misses       9963    10347     +384     
Impacted Files Coverage Δ
src/layer/deformableconv2d.cpp 97.19% <97.19%> (ø)
src/layer/x86/deformableconv2d_x86.cpp 97.91% <97.91%> (ø)
src/command.cpp 72.70% <0.00%> (-14.94%) ⬇️
src/layer/riscv/convolution_3x3_pack1ton_fp16s.h 89.14% <0.00%> (-10.86%) ⬇️
src/pipeline.cpp 58.69% <0.00%> (-2.18%) ⬇️
src/layer/vulkan/reshape_vulkan.cpp 92.01% <0.00%> (-2.14%) ⬇️
src/layer/vulkan/packing_vulkan.cpp 81.70% <0.00%> (-1.88%) ⬇️
src/layer/vulkan/permute_vulkan.cpp 96.99% <0.00%> (-1.60%) ⬇️
src/layer/vulkan/reorg_vulkan.cpp 96.35% <0.00%> (-1.57%) ⬇️
src/layer/vulkan/pixelshuffle_vulkan.cpp 96.35% <0.00%> (-1.57%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f0d89...c405dfd. Read the comment docs.

@nihui
Copy link
Member

nihui commented Jul 24, 2022

hi, please enable github action in your fork to make code-format bot work properly

@nihui
Copy link
Member

nihui commented Jul 24, 2022

please add unittest for new operator
please add new operator doc in docs/developer-guide/operators.md

@nihui nihui closed this Jul 25, 2022
@nihui nihui reopened this Jul 25, 2022
@nihui nihui merged commit 720f3c9 into Tencent:master Jul 28, 2022
@nihui
Copy link
Member

nihui commented Jul 28, 2022

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants