Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add space site and fix some bug #789

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

GuYith
Copy link
Contributor

@GuYith GuYith commented Aug 15, 2023

完善space的site,发现并解决之前的几个小bug

待解决问题

  • 依旧是propsType,还待研究透,实现space的时候,当propsType中写了breakLine、separator的时候,会导致无法正确获得对应的prop,显示为null或defaultProps中的值,注释掉之后,则能正常获取。

image

@GuYith GuYith mentioned this pull request Aug 15, 2023
72 tasks
@dntzhang
Copy link
Collaborator

dntzhang commented Aug 16, 2023

哦。propTypes是用于html模式。render的时候加一个开关可以忽略掉 html 模式的attr。我来看一下原因

@dntzhang dntzhang merged commit 29278c2 into Tencent:master Aug 16, 2023
@dntzhang
Copy link
Collaborator

@GuYith 09ee924

好了,你看我这次提交就知道原因了。

@GuYith
Copy link
Contributor Author

GuYith commented Aug 16, 2023

@GuYith 09ee924

好了,你看我这次提交就知道原因了。

感谢解答!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants