Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on windows with clang #1217

Merged
merged 1 commit into from Apr 25, 2018
Merged

Conversation

DirtYiCE
Copy link

@DirtYiCE DirtYiCE commented Apr 6, 2018

Currently rapidjson produces many warning messages when compiling it with clang-cl on windows using MSVC 2017 libraries. The problem is that in this case _MSC_VER and __clang__ are both defined, and the headers doesn't handle this case correctly.

The file test/unittest/schematest.cpp had a compile error under gcc with -Werror=effc++ since include/rapidjson/internal/regex.h didn't pop the diagnostic in case of gcc.

@coveralls
Copy link

coveralls commented Apr 6, 2018

Coverage Status

Coverage remained the same at 99.92% when pulling 0fdd804 on tresorit:win-clang-fix into 8022a5f on Tencent:master.

@steveire
Copy link
Contributor

Please also integrate the change in #1231 into this one.

@miloyip miloyip merged commit b32cd94 into Tencent:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants