Fix compilation on windows with clang #1217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rapidjson produces many warning messages when compiling it with clang-cl on windows using MSVC 2017 libraries. The problem is that in this case
_MSC_VER
and__clang__
are both defined, and the headers doesn't handle this case correctly.The file
test/unittest/schematest.cpp
had a compile error under gcc with-Werror=effc++
sinceinclude/rapidjson/internal/regex.h
didn't pop the diagnostic in case of gcc.