Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test: Parsing "0e100" in full precision mode causes UB #1250

Merged
merged 4 commits into from Jun 18, 2018
Merged

Unit Test: Parsing "0e100" in full precision mode causes UB #1250

merged 4 commits into from Jun 18, 2018

Conversation

StilesCrisis
Copy link
Contributor

@StilesCrisis StilesCrisis commented May 11, 2018 •
edited

Added a test demonstrating #1249 (0e100 invokes undefined behavior in full precision mode)

StilesCrisis
StilesCrisis commented May 11, 2018
View reviewed changes
Copy link
Contributor Author

@StilesCrisis StilesCrisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved comment by referencing issue number

@StilesCrisis StilesCrisis mentioned this pull request May 11, 2018
Closed
@StilesCrisis StilesCrisis changed the title Issue 1249 test Unit Test: Parsing "0e100" in full precision mode causes UB May 11, 2018
@coveralls
Copy link

coveralls commented Jun 17, 2018 •
edited

Coverage Status

Coverage increased (+0.0004%) to 99.921% when pulling cad3805 on StilesCrisis:issue-1249-test into a091035 on Tencent:master.

@miloyip miloyip merged commit c511ce3 into Tencent:master Jun 18, 2018
@StilesCrisis StilesCrisis deleted the issue-1249-test branch June 18, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StilesCrisis @coveralls @miloyip