Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from PR #1485, should probably live on its own...
The issue is, from
valuetest.cpp::MergeDuplicateKey()
:Without the fix, in current
GenericValue& operator=(GenericValue&)
,itr->value.~GenericValue()
gets called beforeitr->value.RawAssign(itr->value[0])
and thusitr->value[0]
may be used after free (with akneedFree
allocator).PS: the VC2013 compilation fix for
sortkeys.cpp
is also included here to pass ci.