Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Canonicalize rapidjson include path in RapidJSONConfig.cmake. #1505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastianbeischer
Copy link

Having the path without relative components allows other projects to add the
RadidJSON_INCLUDE_DIRS as a system include directory, without causing problems
in the build.

Having the path without relative components allows other projects to add the
RadidJSON_INCLUDE_DIRS as a system include directory, without causing problems
in the build.
@tencent-adm
Copy link

tencent-adm commented Apr 29, 2019

CLA assistant check
All committers have signed the CLA.

@bastianbeischer
Copy link
Author

See discussion in:

MaskRay/ccls#383

(specifically the last comment)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.922% when pulling c9b57bd on bastianbeischer:cmake into 01950eb on Tencent:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 99.922% when pulling c9b57bd on bastianbeischer:cmake into 01950eb on Tencent:master.

@smancill
Copy link

smancill commented Sep 10, 2019

I fixed issues with the install locations in PR #1454, see commits deecf8c and 425c1e7.

Would that fix the problem? I think using configure_package_config_file is better.

@bastianbeischer
Copy link
Author

I fixed issues with the install locations in PR #1454, see commits deecf8c and 425c1e7.

Would that fix the problem? I think using configure_package_config_file is better.

Yes, your PR also fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants