Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation fixes #241

Merged
merged 2 commits into from Feb 23, 2015
Merged

Compilation fixes #241

merged 2 commits into from Feb 23, 2015

Conversation

yachoor
Copy link
Contributor

@yachoor yachoor commented Feb 14, 2015

Fixes compilation issues with some less common configurations:

  • compiler that does not import c stdlib functions into global namespace when including through c++ headers (cstring vs string.h)
  • platform with uint32_t typedefed to 32-bit unsigned long and uint64_t to 64-bit unsigned long long - compiler cannot decide between overloads when using unsigned int literal

@pah
Copy link
Contributor

pah commented Feb 14, 2015

LGTM 👍

Which platform are you using? The second bullet is in fact one of my main objections against the adoptions of #149.

@yachoor
Copy link
Contributor Author

yachoor commented Feb 15, 2015

I got this error during compilation using arm-elf-gcc 4.3.2 toolchain, targeting ARM922T processor.

miloyip added a commit that referenced this pull request Feb 23, 2015
@miloyip
Merge pull request #241 from yachoor/compilation_fixes
3804a06 
Compilation fixes
@miloyip miloyip merged commit 3804a06 into Tencent:master Feb 23, 2015
@yachoor yachoor deleted the compilation_fixes branch February 25, 2015 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yachoor @pah @miloyip