Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer overrun using PutN (closes #672) #673

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Fix buffer overrun using PutN (closes #672) #673

merged 1 commit into from
Jul 1, 2016

Commits on Jun 30, 2016

  1. Fix buffer overrun using PutN (closes Tencent#672) 

    Fix inconsistent calling of template functions in PutN in stream.h. When
used with a GenericStringBuffer<<UTF8>, MemoryPoolAllocator>, PutN would call
PutReserve from stream.h, and PutUnsafe from stringbuffer.h. This
resulted in bytes being added to the buffer without allocating space.

This was not an issue when used with the default memory allocator,
because in this case the specialized PutN is used from stringbuffer.h.
    @sjasonsmith
    sjasonsmith committed Jun 30, 2016
    Configuration menu
    Copy the full SHA
    252e812 View commit details
    Browse the repository at this point in the history