-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move constructor support for Writer #740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreoValis
force-pushed
the
writer-move-ctor
branch
from
September 19, 2016 17:08
49540ac
to
21a6676
Compare
CreoValis
force-pushed
the
writer-move-ctor
branch
from
September 19, 2016 17:32
21a6676
to
2b73169
Compare
Please add unit tests for code coverage. |
CreoValis
force-pushed
the
writer-move-ctor
branch
from
September 19, 2016 17:52
2b73169
to
878eef8
Compare
Thanks! |
CreoValis
force-pushed
the
writer-move-ctor
branch
2 times, most recently
from
September 19, 2016 18:14
c915e91
to
a5e6ba2
Compare
This also requires turning off the c++98 compatibility checks when building with clang.
CreoValis
force-pushed
the
writer-move-ctor
branch
2 times, most recently
from
September 19, 2016 20:05
3b2156d
to
cf18d90
Compare
CreoValis
force-pushed
the
writer-move-ctor
branch
from
September 19, 2016 20:13
cf18d90
to
1a64cd0
Compare
I've added unit tests for both classes' move constructors, and both CI tests pass now. |
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
internal::Stack
already has a move constructor, it's trivial to write one forWriter
.(Plus, i needed it for a project of mine 😄 .)