Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writer EndObject missing-value fix #869

Merged
merged 4 commits into from
Feb 28, 2017
Merged

Writer EndObject missing-value fix #869

merged 4 commits into from
Feb 28, 2017

Commits on Feb 28, 2017

  1. Merge remote-tracking branch 'miloyip/master'

    StilesCrisis authored and StilesCrisis committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    26e089b View commit details
    Browse the repository at this point in the history

  2. Unit test 

    Add unit tests expecting an assertion when writing an object with a key
but no value.
    StilesCrisis authored and StilesCrisis committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    595b114 View commit details
    Browse the repository at this point in the history

  3. Added assertion 

    Documented existing assertions in EndObject
Added new assertion in EndObject to catch error condition where objects
are ended with a key but no matching value.
    StilesCrisis authored and StilesCrisis committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    2e9b7b1 View commit details
    Browse the repository at this point in the history

  4. Add matching fix for PrettyWriter 

    PrettyWriter EndObject will now also assert if called when a key is
missing its matching value.
    StilesCrisis authored and StilesCrisis committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    fa84cd1 View commit details
    Browse the repository at this point in the history