Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tabs): correct tabs example have same value #2386

Merged
merged 2 commits into from
Oct 18, 2023
Merged

docs(tabs): correct tabs example have same value #2386

merged 2 commits into from
Oct 18, 2023

Conversation

Xcyq
Copy link
Contributor

@Xcyq Xcyq commented Oct 9, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

现在tabs文档里【基础选项卡】的第3个示例代码存在相同的value。这会导致:

  1. 右侧的预览中,无法点击第3行第4个“上限四字”tab;
  2. 有人(比如我...)把这段代码复制到本地后,会发现点击不了tab;

📝 更新日志

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@betavs
Copy link
Collaborator

betavs commented Oct 10, 2023

1 snapshot failed from 1 test suite. Inspect your code changes or run npm run test:unit -- -u to update them.

@Xcyq
Copy link
Contributor Author

Xcyq commented Oct 10, 2023

1 snapshot failed from 1 test suite. Inspect your code changes or run npm run test:unit -- -u to update them.

不好意思,我不知道我修改的部分涉及到unit test,现在补充了一个提交。

@betavs betavs requested a review from anlyyao October 18, 2023 06:45
@LeeJim LeeJim merged commit 036a386 into Tencent:develop Oct 18, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants