Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdownmenu): 改变label定义标题不起效 #1123

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix(dropdownmenu): 改变label定义标题不起效 #1123

merged 1 commit into from
Oct 11, 2023

Conversation

LoopZhou
Copy link
Collaborator

@LoopZhou LoopZhou commented Oct 11, 2023 •
edited by anlyyao
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #1119

💡 需求背景和解决方案

主要解决：

  1. 多选时，通过label来控制标题不起效问题。
  2. 单选时，v-model和defaultValue 初始化时没有标题的问题
    复现示例： https://stackblitz.com/edit/m5k9ia-xxbvmk?file=src%2Fdemo.vue

image

📝 更新日志

  • fix(DropdownMenu): 修复 label 不能响应式更新的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

完成

anlyyao
anlyyao approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@anlyyao anlyyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anlyyao anlyyao merged commit 08fe605 into Tencent:develop Oct 11, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anlyyao anlyyao anlyyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DropdownMenu] 改变title值不起效
2 participants
@LoopZhou @anlyyao