Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(countdown): fix milisecond problem and add unit test #313

Merged
merged 2 commits into from
Sep 20, 2022
Merged

fix(countdown): fix milisecond problem and add unit test #313

merged 2 commits into from
Sep 20, 2022

Conversation

TingShine
Copy link
Contributor

@TingShine TingShine commented Aug 26, 2022 •
edited by LeeJim
Loading

fix #312

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

毫秒级渲染配置无效

💡 需求背景和解决方案

props传入milisecond为true无效

📝 更新日志

  • fix(CountDown): 修复 milisecond 配置无效的问题

  • feat(CountDown): 新增单元测试

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022 •
edited
Loading

完成

@TingShine TingShine changed the title fix(countdown): fix miliseconds problem fix(countdown): fix miliseconds problem and add test unit Aug 26, 2022
@TingShine TingShine changed the title fix(countdown): fix miliseconds problem and add test unit fix(countdown): fix milisecond problem and add unit test Aug 26, 2022
@anlyyao anlyyao mentioned this pull request Aug 29, 2022
Closed
50 tasks
@anlyyao
Copy link
Collaborator

anlyyao commented Aug 29, 2022

@TingShine 辛苦合一下 dev 分支，重跑一下 ci～

@anlyyao
Copy link
Collaborator

anlyyao commented Sep 6, 2022

补充一下徽标即可～

@anlyyao anlyyao requested a review from LeeJim September 13, 2022 02:44
LeeJim
LeeJim requested changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

存在两个问题。
1 一个 PR 里有两个组件的单测，需要拆分，分别提交
2 git 分支有问题，diff 有问题，提交了 script 的代码

@LeeJim LeeJim added the in progress 正在处理中 label Sep 16, 2022
@LeeJim LeeJim merged commit 6fb8f38 into Tencent:develop Sep 20, 2022
@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeJim LeeJim LeeJim approved these changes

Assignees
No one assigned
Labels
in progress 正在处理中
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CountDown] 毫秒级渲染配置无效
3 participants
@TingShine @anlyyao @LeeJim