Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popup): using new style #605

Merged
merged 6 commits into from
Apr 20, 2023
Merged

fix(popup): using new style #605

merged 6 commits into from
Apr 20, 2023

Conversation

LeeJim
Copy link
Collaborator

@LeeJim LeeJim commented Apr 18, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

重构 Popup

📝 更新日志

  • break(Popup): 调整 DOM

  • break(Popup): 属性 to 更名为 attach

  • break(Popup): 移除 customStyle 属性,可以直接使用 style

  • break(Popup): 属性 lockScroll 更名为 preventScrollThrough

  • feat(Popup): 新增 closeBtn 属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@LeeJim LeeJim mentioned this pull request Apr 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

完成

@github-actions
Copy link
Contributor

Size Change: +836 B (0%)

Total Size: 443 kB

Filename Size Change
./dist/tdesign.css 36.2 kB +84 B (0%)
./dist/tdesign.js 257 kB +426 B (0%)
./dist/tdesign.min.css 28.1 kB +288 B (+1%)
./dist/tdesign.min.js 122 kB +38 B (0%)

@github-actions
Copy link
Contributor

Size Change: +1.08 kB (0%)

Total Size: 443 kB

Filename Size Change
./dist/tdesign.css 36 kB +333 B (+1%)
./dist/tdesign.js 257 kB +426 B (0%)
./dist/tdesign.min.css 27.9 kB +286 B (+1%)
./dist/tdesign.min.js 122 kB +38 B (0%)

@github-actions
Copy link
Contributor

Size Change: +1.1 kB (0%)

Total Size: 443 kB

Filename Size Change
./dist/tdesign.css 36 kB +333 B (+1%)
./dist/tdesign.js 257 kB +435 B (0%)
./dist/tdesign.min.css 27.9 kB +286 B (+1%)
./dist/tdesign.min.js 122 kB +48 B (0%)

@github-actions
Copy link
Contributor

Size Change: +1.1 kB (0%)

Total Size: 443 kB

Filename Size Change
./dist/tdesign.css 36 kB +333 B (+1%)
./dist/tdesign.js 257 kB +400 B (0%)
./dist/tdesign.min.css 27.9 kB +286 B (+1%)
./dist/tdesign.min.js 122 kB +78 B (0%)

@github-actions
Copy link
Contributor

Size Change: +1.1 kB (0%)

Total Size: 443 kB

Filename Size Change
./dist/tdesign.css 36 kB +333 B (+1%)
./dist/tdesign.js 257 kB +400 B (0%)
./dist/tdesign.min.css 27.9 kB +286 B (+1%)
./dist/tdesign.min.js 122 kB +78 B (0%)

@github-actions
Copy link
Contributor

Size Change: +1.1 kB (0%)

Total Size: 443 kB

Filename Size Change
./dist/tdesign.css 36 kB +333 B (+1%)
./dist/tdesign.js 257 kB +400 B (0%)
./dist/tdesign.min.css 27.9 kB +286 B (+1%)
./dist/tdesign.min.js 122 kB +78 B (0%)

@LeeJim LeeJim merged commit 68f1077 into develop Apr 20, 2023
@LeeJim LeeJim deleted the feat/new-popup branch April 20, 2023 09:25
@github-actions github-actions bot mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant