Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new dropdown menu #695

Merged
merged 6 commits into from
May 30, 2023
Merged

feat: new dropdown menu #695

merged 6 commits into from
May 30, 2023

Conversation

ccccpj
Copy link
Collaborator

@ccccpj ccccpj commented May 24, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • break(DropdownMenu): 调整 DOM

  • break(DropdownMenu): 移除 activeColor 属性

  • break(DropdownMenu): 属性 overlay 更名为 showOverlay

  • feat(DropdownMenu): 新增 confirmreset 事件

  • feat(DropdownMenu): 新增 footer 插槽

  • feat(DropdownMenuItem): 新增 keys 属性

  • feat(Checkbox): icon 新增 boolean 类型

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@ccccpj ccccpj requested a review from anlyyao May 24, 2023 07:12
@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

完成

@github-actions
Copy link
Contributor

Size Change: -2.6 kB (-1%)

Total Size: 453 kB

Filename Size Change
./dist/tdesign.css 30.4 kB -312 B (-1%)
./dist/tdesign.js 272 kB -1.24 kB (0%)
./dist/tdesign.min.css 22.3 kB -351 B (-2%)
./dist/tdesign.min.js 129 kB -695 B (-1%)

@github-actions
Copy link
Contributor

Size Change: -2.72 kB (-1%)

Total Size: 453 kB

Filename Size Change
./dist/tdesign.css 30.4 kB -487 B (-2%)
./dist/tdesign.js 272 kB -1.11 kB (0%)
./dist/tdesign.min.css 22.3 kB -510 B (-2%)
./dist/tdesign.min.js 129 kB -621 B (0%)

src/dropdown-menu/dropdown-item.vue Outdated Show resolved Hide resolved
src/dropdown-menu/type.ts Show resolved Hide resolved
src/dropdown-menu/dropdown-item.vue Show resolved Hide resolved
src/dropdown-menu/dropdown-item.vue Show resolved Hide resolved
src/dropdown-menu/dropdown-item.vue Show resolved Hide resolved
src/dropdown-menu/dropdown-menu.vue Outdated Show resolved Hide resolved
@anlyyao
Copy link
Collaborator

anlyyao commented May 25, 2023

@ccccpj 是不是还漏了一个 duration 属性?

@github-actions
Copy link
Contributor

Size Change: -2.24 kB (0%)

Total Size: 454 kB

Filename Size Change
./dist/tdesign.css 30.4 kB -487 B (-2%)
./dist/tdesign.js 272 kB -813 B (0%)
./dist/tdesign.min.css 22.3 kB -510 B (-2%)
./dist/tdesign.min.js 129 kB -428 B (0%)

@anlyyao
Copy link
Collaborator

anlyyao commented May 29, 2023

@ccccpj 两个列之间的展开和关闭切换的时候 有点问题 数据更新不对

2023-05-29.18.29.31.mov

@github-actions
Copy link
Contributor

Size Change: -2.14 kB (0%)

Total Size: 454 kB

Filename Size Change
./dist/tdesign.css 30.4 kB -487 B (-2%)
./dist/tdesign.js 272 kB -759 B (0%)
./dist/tdesign.min.css 22.3 kB -510 B (-2%)
./dist/tdesign.min.js 129 kB -383 B (0%)

@github-actions
Copy link
Contributor

Size Change: -1.91 kB (0%)

Total Size: 454 kB

Filename Size Change
./dist/tdesign.css 30.4 kB -487 B (-2%)
./dist/tdesign.js 272 kB -630 B (0%)
./dist/tdesign.min.css 22.3 kB -510 B (-2%)
./dist/tdesign.min.js 129 kB -280 B (0%)

@github-actions
Copy link
Contributor

Size Change: +12.8 kB (+3%)

Total Size: 469 kB

Filename Size Change
./dist/tdesign.css 35.1 kB +4.15 kB (+13%) ⚠️
./dist/tdesign.js 276 kB +2.94 kB (+1%)
./dist/tdesign.min.css 25.5 kB +2.73 kB (+12%) ⚠️
./dist/tdesign.min.js 133 kB +3.02 kB (+2%)

@anlyyao anlyyao merged commit c17cf72 into develop May 30, 2023
8 checks passed
@anlyyao anlyyao deleted the feat/new-dropdown-menu-2 branch May 30, 2023 11:56
@github-actions github-actions bot mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants