Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popup): resolved closeBtn invalid when using slot #753

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

anlyyao
Copy link
Collaborator

@anlyyao anlyyao commented May 31, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Popup): 解决使用 closeBtn 插槽时关闭无效的问题

  • test(Popup): 补充测试用例

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

Size Change: +31 B (0%)

Total Size: 469 kB

Filename Size Change
./dist/tdesign.js 276 kB +15 B (0%)
./dist/tdesign.min.js 133 kB +16 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 35.1 kB
./dist/tdesign.min.css 25.5 kB

@github-actions
Copy link
Contributor

完成

@LeeJim LeeJim merged commit 5bd3e7f into develop Jun 1, 2023
10 checks passed
@LeeJim LeeJim deleted the test/popup branch June 1, 2023 02:35
@anlyyao anlyyao linked an issue Jun 1, 2023 that may be closed by this pull request
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【popup】测试覆盖率提升
2 participants