Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): auto scroll behavior #2779

Merged
merged 4 commits into from
Feb 29, 2024
Merged

fix(select): auto scroll behavior #2779

merged 4 commits into from
Feb 29, 2024

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Feb 29, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  • 选中值后 会因为滚动触发更新 导致滚动加载无法正常完成
image
  • updateScrollTop只在popup visible变为true 执行即可 目前因为updateScrollTop会多次重复执行

📝 更新日志

  • fix(Select): 修复通过滚动加载选项选中后滚动行为异常的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Feb 29, 2024

完成

@HaixingOoO
Copy link
Collaborator

HaixingOoO commented Feb 29, 2024

DatePicker的年份和月份滚动加载更多没有重新定位到指定的地方了,要么加个Throttle来优化滚动多次触发的问题

@HaixingOoO
Copy link
Collaborator

要么在后续的滚动加载更多这里,再触发更新滚动事件?

@HaixingOoO HaixingOoO merged commit 82a5acc into develop Feb 29, 2024
5 checks passed
@HaixingOoO HaixingOoO deleted the fix/select-scroll branch February 29, 2024 05:56
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants