Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Guide): fix guide initial position in ssr #2832

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Apr 2, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  • createPortal 在 SSR 场景不会执行,在 SSR 中使用 Guide 初始化时会找不到节点,导致高亮渲染位置错位,调整为useLayoutEffect 保证在 Client 运行

📝 更新日志

  • fix(Guide): 修复Guide组件在SSR场景初始化渲染位置异常的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Apr 2, 2024

完成

@HaixingOoO HaixingOoO merged commit f2498c6 into develop Apr 7, 2024
5 checks passed
@HaixingOoO HaixingOoO deleted the fix/guide-ssr branch April 7, 2024 02:44
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants