Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove global reset style #899

Merged
merged 11 commits into from
Jun 27, 2022
Merged

feat: remove global reset style #899

merged 11 commits into from
Jun 27, 2022

Conversation

xiaosansiji
Copy link
Collaborator

@xiaosansiji xiaosansiji commented Jun 17, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

common pr: Tencent/tdesign-common#514

组件情况走查地址(屏蔽官网 reset 样式干扰):https://preview-pr899-tdesign-react.surge.sh/playground.html#/demos/button

📝 更新日志

  • feat: 去除全局 reset 样式,改为组件内部实现

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #899 (bf8861b) into develop (8fdcb64) will decrease coverage by 0.41%.
The diff coverage is 47.52%.

@@             Coverage Diff             @@
##           develop     #899      +/-   ##
===========================================
- Coverage    60.81%   60.40%   -0.42%     
===========================================
  Files          914      937      +23     
  Lines        15385    16498    +1113     
  Branches      3467     3743     +276     
===========================================
+ Hits          9357     9966     +609     
- Misses        6028     6532     +504     
Impacted Files Coverage Δ
src/_util/callBoth.ts 0.00% <ø> (ø)
src/_util/dom.ts 42.59% <0.00%> (+1.85%) ⬆️
src/alert/_example/base.jsx 100.00% <ø> (ø)
src/alert/_example/close.jsx 100.00% <ø> (ø)
src/alert/_example/icon.jsx 100.00% <ø> (ø)
src/alert/_example/operation.jsx 100.00% <ø> (ø)
src/alert/_example/swiper.jsx 100.00% <ø> (ø)
src/avatar/_example/adjust.jsx 100.00% <ø> (ø)
src/avatar/_example/base.jsx 100.00% <ø> (ø)
src/avatar/_example/group-cascading.jsx 100.00% <ø> (ø)
... and 375 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d6807...bf8861b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022

完成

@honkinglin
Copy link
Collaborator

https://preview-pr899-tdesign-react.surge.sh/playground.html
可用这个地址预览

@honkinglin
Copy link
Collaborator

re #806

@honkinglin honkinglin merged commit c4dc73d into develop Jun 27, 2022
@honkinglin honkinglin deleted the fix/reset/style branch June 27, 2022 07:24
@github-actions github-actions bot mentioned this pull request Jun 27, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants