Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): async loading size #907

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix(table): async loading size #907

merged 1 commit into from
Jun 20, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jun 20, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

Tencent/tdesign-common#507 中移除了对Table组件中Loading组件的大小设置 忽略了加载更多这里的样式问题 同样需要增加size small处理

📝 更新日志

  • fix(table): 修复加载更多的加载组件尺寸异常问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #907 (a9b4af7) into develop (8fdcb64) will decrease coverage by 0.52%.
The diff coverage is 48.42%.

@@             Coverage Diff             @@
##           develop     #907      +/-   ##
===========================================
- Coverage    60.81%   60.28%   -0.53%     
===========================================
  Files          914      930      +16     
  Lines        15385    16419    +1034     
  Branches      3467     3716     +249     
===========================================
+ Hits          9357     9899     +542     
- Misses        6028     6520     +492     
Impacted Files Coverage Δ
src/addon/Addon.tsx 0.00% <0.00%> (-92.31%) ⬇️
src/button/defaultProps.ts 100.00% <ø> (ø)
src/cascader/defaultProps.ts 100.00% <ø> (ø)
src/checkbox/defaultProps.ts 100.00% <ø> (ø)
src/color-picker/defaultProps.ts 100.00% <ø> (ø)
src/comment/Comment.tsx 95.45% <ø> (ø)
src/date-picker/DateRangePicker.tsx 10.41% <0.00%> (-0.46%) ⬇️
src/date-picker/base/Cell.tsx 20.00% <0.00%> (+13.33%) ⬆️
src/date-picker/base/Footer.tsx 73.33% <0.00%> (+59.04%) ⬆️
src/date-picker/base/Header.tsx 42.42% <ø> (+37.87%) ⬆️
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c657e...a9b4af7. Read the comment docs.

@github-actions
Copy link
Contributor

完成

@chaishi chaishi merged commit 63cbc37 into develop Jun 20, 2022
@chaishi chaishi deleted the fix/table-async-loading branch June 20, 2022 04:27
@github-actions github-actions bot mentioned this pull request Jun 27, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants