Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): fix regexp error when filter value contains special characters #916

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

richerfu
Copy link
Contributor

@richerfu richerfu commented Jun 21, 2022

…acters

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#906

💡 需求背景和解决方案

📝 更新日志

  • fix(Select): 修复输入部分特殊符号过滤时组件崩溃的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #916 (47c8f31) into develop (8fdcb64) will decrease coverage by 0.43%.
The diff coverage is 50.83%.

@@             Coverage Diff             @@
##           develop     #916      +/-   ##
===========================================
- Coverage    60.81%   60.38%   -0.44%     
===========================================
  Files          914      939      +25     
  Lines        15385    16482    +1097     
  Branches      3467     3731     +264     
===========================================
+ Hits          9357     9953     +596     
- Misses        6028     6529     +501     
Impacted Files Coverage Δ
src/button/defaultProps.ts 100.00% <ø> (ø)
src/cascader/defaultProps.ts 100.00% <ø> (ø)
src/checkbox/defaultProps.ts 100.00% <ø> (ø)
src/color-picker/defaultProps.ts 100.00% <ø> (ø)
src/comment/Comment.tsx 95.45% <ø> (ø)
src/date-picker/DateRangePicker.tsx 10.41% <0.00%> (-0.46%) ⬇️
src/date-picker/base/Cell.tsx 20.00% <0.00%> (+13.33%) ⬆️
src/date-picker/base/Footer.tsx 73.33% <0.00%> (+59.04%) ⬆️
src/date-picker/base/Header.tsx 42.42% <ø> (+37.87%) ⬆️
src/date-picker/defaultProps.ts 100.00% <ø> (ø)
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e2873...47c8f31. Read the comment docs.

@github-actions
Copy link
Contributor

完成

Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn uyarn merged commit adf52b0 into Tencent:develop Jun 22, 2022
@github-actions github-actions bot mentioned this pull request Jun 27, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants