fix(slider): fix slider click event bug #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
问题：Slider组件使用inputNumberProp时，点击滑动条无法把值同步到InputNumber组件
原因：InputNumber组件有个判断是否使用当下Slider上一次渲染值，但click逻辑中没有在每次完成操作后同步更新该值，并且把该值用作渲染InputNumber组件的参数
解决办法：排查发现旧版逻辑中存在prevValue属性来记录上一次的滑动值，但该值只在拖拽时被同步且被用于赋值给sliderButton的位置计算属性。经过考虑和调试，完全可以移除该值，直接以Slider的value值去替代来避免每次click滑动条导致值同步差异问题
📝 更新日志
Slider组件使用inputNumberProp时，点击滑动条无法把值同步到InputNumber组件问题☑️ 请求合并前的自查清单