Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(loading): use composition API to refactor loading #212

Merged
merged 3 commits into from Jan 18, 2022
Merged

refactor(loading): use composition API to refactor loading #212

merged 3 commits into from Jan 18, 2022

Conversation

uyarn
Copy link
Collaborator

@uyarn uyarn commented Jan 16, 2022 •
edited

  1. 使用vue3 composition API重构Loading组件。
  2. loading部分框架无关代码统一使用common中复用代码 方便维护。
  3. 去掉attach demo中无效的一行div 此改动同时需要更新snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2022 •
edited

PR 预览产物在 https://preview-pr212-tdesign-vue-next.surge.sh

@uyarn uyarn requested a review from PengYYYYY January 16, 2022 16:46
@uyarn uyarn changed the title [WIP] refactor(loading): composition API refactor(loading): composition API Jan 16, 2022
@uyarn uyarn changed the title refactor(loading): composition API refactor(loading): use composition API to refactor loading Jan 16, 2022
@uyarn uyarn changed the base branch from develop to compositionAPI January 17, 2022 03:22
@uyarn
Copy link
Collaborator Author

uyarn commented Jan 17, 2022

#58

PengYYYYY
PengYYYYY approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@PengYYYYY PengYYYYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PengYYYYY
Copy link
Collaborator

image
这个demo开启loading 后关闭，demo区域无法滚动了。

@PengYYYYY PengYYYYY merged commit baee597 into compositionAPI Jan 18, 2022
@PengYYYYY PengYYYYY deleted the refactor/loading branch January 18, 2022 02:32
@PengYYYYY PengYYYYY mentioned this pull request Mar 8, 2022
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uyarn @PengYYYYY